From 1906d0de0df4585784c6453271d0d7004c52d67b Mon Sep 17 00:00:00 2001
From: martinshoob <velebilmartin@gmail.com>
Date: Mon, 11 Aug 2025 18:18:31 +0200
Subject: [PATCH] Remove explicit fail call in admin authorization

---
 .../AdminOnlyRequirement.cs                   | 19 +++----------------
 1 file changed, 3 insertions(+), 16 deletions(-)

diff --git a/DrinkRateAPI/AuthorizationPolicies/AdminOnlyRequirement.cs b/DrinkRateAPI/AuthorizationPolicies/AdminOnlyRequirement.cs
index e972e3b..f850568 100644
--- a/DrinkRateAPI/AuthorizationPolicies/AdminOnlyRequirement.cs
+++ b/DrinkRateAPI/AuthorizationPolicies/AdminOnlyRequirement.cs
@@ -2,6 +2,7 @@ using DrinkRateAPI.DbEntities;
 using DrinkRateAPI.Services;
 
 namespace DrinkRateAPI.AuthorizationPolicies;
+
 using Microsoft.AspNetCore.Authorization;
 
 public class AdminOnlyRequirement : IAuthorizationRequirement
@@ -22,28 +23,14 @@ public class AdminOnlyHandler : AuthorizationHandler<AdminOnlyRequirement>
     }
 
     protected override async Task HandleRequirementAsync(
-        AuthorizationHandlerContext context, 
+        AuthorizationHandlerContext context,
         AdminOnlyRequirement requirement)
     {
-        DbUserProfile userProfile;
-        
-        try
-        {
-            userProfile = await _applicationUserService.UserProfileByApplicationUserAsync(context.User);
-        }
-        catch (Exception _)
-        {
-            context.Fail();
-            return;
-        }
+        var userProfile = await _applicationUserService.UserProfileByApplicationUserAsync(context.User);
 
         if (_userProfileService.IsUserProfileAdmin(userProfile))
         {
             context.Succeed(requirement);
         }
-        else
-        {
-            context.Fail();
-        }
     }
 }
\ No newline at end of file