Enhance AdminOnly authorization policy
Refactor the AdminOnly authorization policy to handle cases where a user profile is not found. Instead of throwing a NotFoundException, it now throws a ForbiddenException, ensuring a more appropriate response for unauthorized access attempts. Also introduces PolicyConstants for policy names.
This commit is contained in:
parent
1dc37d3282
commit
9ec9139f69
4 changed files with 22 additions and 3 deletions
|
@ -1,4 +1,5 @@
|
||||||
using DrinkRateAPI.DbEntities;
|
using DrinkRateAPI.DbEntities;
|
||||||
|
using DrinkRateAPI.Exceptions;
|
||||||
using DrinkRateAPI.Services;
|
using DrinkRateAPI.Services;
|
||||||
|
|
||||||
namespace DrinkRateAPI.AuthorizationPolicies;
|
namespace DrinkRateAPI.AuthorizationPolicies;
|
||||||
|
@ -26,7 +27,16 @@ public class AdminOnlyHandler : AuthorizationHandler<AdminOnlyRequirement>
|
||||||
AuthorizationHandlerContext context,
|
AuthorizationHandlerContext context,
|
||||||
AdminOnlyRequirement requirement)
|
AdminOnlyRequirement requirement)
|
||||||
{
|
{
|
||||||
var userProfile = await _applicationUserService.UserProfileByApplicationUserAsync(context.User);
|
DbUserProfile userProfile;
|
||||||
|
|
||||||
|
try
|
||||||
|
{
|
||||||
|
userProfile = await _applicationUserService.UserProfileByApplicationUserAsync(context.User);
|
||||||
|
}
|
||||||
|
catch (NotFoundException _)
|
||||||
|
{
|
||||||
|
throw new ForbiddenException();
|
||||||
|
}
|
||||||
|
|
||||||
if (_userProfileService.IsUserProfileAdmin(userProfile))
|
if (_userProfileService.IsUserProfileAdmin(userProfile))
|
||||||
{
|
{
|
||||||
|
|
7
DrinkRateAPI/AuthorizationPolicies/PolicyConstants.cs
Normal file
7
DrinkRateAPI/AuthorizationPolicies/PolicyConstants.cs
Normal file
|
@ -0,0 +1,7 @@
|
||||||
|
namespace DrinkRateAPI.AuthorizationPolicies;
|
||||||
|
|
||||||
|
public static class PolicyConstants
|
||||||
|
{
|
||||||
|
public const string AdminOnly = "AdminOnly";
|
||||||
|
|
||||||
|
}
|
|
@ -1,5 +1,6 @@
|
||||||
using System.Security.Claims;
|
using System.Security.Claims;
|
||||||
using DrinkRateAPI.ApiModels.UserProfile;
|
using DrinkRateAPI.ApiModels.UserProfile;
|
||||||
|
using DrinkRateAPI.AuthorizationPolicies;
|
||||||
using DrinkRateAPI.Services;
|
using DrinkRateAPI.Services;
|
||||||
using Microsoft.AspNetCore.Authorization;
|
using Microsoft.AspNetCore.Authorization;
|
||||||
using Microsoft.AspNetCore.Mvc;
|
using Microsoft.AspNetCore.Mvc;
|
||||||
|
@ -28,7 +29,7 @@ public class UserProfileController : ControllerBase
|
||||||
}
|
}
|
||||||
|
|
||||||
[HttpPut("{userId}/adminStatus")]
|
[HttpPut("{userId}/adminStatus")]
|
||||||
[Authorize(Policy = "AdminOnly")]
|
[Authorize(Policy = PolicyConstants.AdminOnly)]
|
||||||
[Produces("application/json")]
|
[Produces("application/json")]
|
||||||
public async Task<IActionResult> PutUserAdminStatus(string userId, [FromBody] UserProfileAdminStatusPut body)
|
public async Task<IActionResult> PutUserAdminStatus(string userId, [FromBody] UserProfileAdminStatusPut body)
|
||||||
{
|
{
|
||||||
|
|
|
@ -15,7 +15,7 @@ builder.Services.AddControllers();
|
||||||
// Learn more about configuring Swagger/OpenAPI at https://aka.ms/aspnetcore/swashbuckle
|
// Learn more about configuring Swagger/OpenAPI at https://aka.ms/aspnetcore/swashbuckle
|
||||||
builder.Services.AddEndpointsApiExplorer();
|
builder.Services.AddEndpointsApiExplorer();
|
||||||
builder.Services.AddAuthorizationBuilder()
|
builder.Services.AddAuthorizationBuilder()
|
||||||
.AddPolicy("AdminOnly", policy =>
|
.AddPolicy(PolicyConstants.AdminOnly, policy =>
|
||||||
policy.Requirements.Add(new AdminOnlyRequirement()));
|
policy.Requirements.Add(new AdminOnlyRequirement()));
|
||||||
builder.Services.AddIdentityApiEndpoints<DbApplicationUser>()
|
builder.Services.AddIdentityApiEndpoints<DbApplicationUser>()
|
||||||
.AddEntityFrameworkStores<ApplicationDbContext>();
|
.AddEntityFrameworkStores<ApplicationDbContext>();
|
||||||
|
@ -58,6 +58,7 @@ builder.Services.AddSwaggerGen(c =>
|
||||||
builder.Services.AddDbContext<ApplicationDbContext>();
|
builder.Services.AddDbContext<ApplicationDbContext>();
|
||||||
builder.Services.AddScoped<ApplicationUserService>();
|
builder.Services.AddScoped<ApplicationUserService>();
|
||||||
builder.Services.AddScoped<UserProfileService>();
|
builder.Services.AddScoped<UserProfileService>();
|
||||||
|
builder.Services.AddScoped<ProductTableService>();
|
||||||
|
|
||||||
var app = builder.Build();
|
var app = builder.Build();
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue